Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sai/options tab db properties #23448

Merged
merged 49 commits into from
Jul 6, 2023
Merged

Sai/options tab db properties #23448

merged 49 commits into from
Jul 6, 2023

Conversation

ssreerama
Copy link
Contributor

@ssreerama ssreerama commented Jun 22, 2023 •
edited
Loading

This PR changes add the ability to View/Modify the database properties through the options tab. Below image is for Local/On-Prem/ManagedInstance properties dialog window.

TODO:

  1. Tests
  2. Database Scoped Configuration (would be a new PRs)

image

ssreerama and others added 30 commits June 5, 2023 08:26
@ssreerama
Initial commit for adding a basic general tab for the database proper…
ca43ade 
…ties
@ssreerama
Refactoring for dialog inputs
ca0ad70
@ssreerama
removed properties nodeType and using database node and additional cl…
1a9094a 
…eanup, diabling the functionality.
@ssreerama
Changes according to STS data fetch
84d24c7
@ssreerama
Merge branch 'main' into 'sai/databasePropertiesInitial'
54ebf98
@ssreerama
Reuse database Dialog
8733af8
@ssreerama
Undo contract file change
10beedc
@ssreerama
more refactoring
8caf792
@ssreerama
fetched scrollbar fix into this PR
09475f1
@ssreerama
Tabbed panel is being used for horizontal tabs
cfbabdf
@ssreerama
stying fix for general tab button
cd2feb5
@ssreerama
Merge branch 'main' into 'sai/databasePropertiesInitial'
8be6593
@ssreerama
Merge branch 'main' into 'sai/databasePropertiesInitial'
1cf0f50
@ssreerama
final commit for today :)
86585b1
@ssreerama
Merge branch 'main' into 'sai/databasePropertiesInitial'
31e4532
@ssreerama
Updates according to STS changes
552a35e
@ssreerama
missed updates
1bbc647
@ssreerama
Refactored updates
7a112c7
@ssreerama
Merge branch 'main' into 'sai/databasePropertiesInitial'
38844ce
@ssreerama
moved options as discussed and added collapsible sections... need to …
9465829 
…fix scroll bar
@ssreerama
Fixing the horizontal scroll bar of tabbedpanel
03217e6
@ssreerama
initial updates
8e85839
@ssreerama
Merge branch 'main' into sai/optionsTab_dbProperties
4166a80
@ssreerama
need to fix the error!
52c1e46
@ssreerama
rror fixed and options are loading with sample values
6510f2d
@ssreerama
need to load real values for all felds and map values to dropdown opt…
163e14e 
…ions
@ssreerama
Dd loading correctly, need to add validation to recovery field and sa…
e150396 
…ve options back
@ssreerama
refactor
63cc8f0
@ssreerama
Merge branch 'main' into sai/optionsTab_dbProperties
be6e870
@ssreerama
removing nullable property
feba07e
@ssreerama ssreerama marked this pull request as ready for review June 29, 2023 20:07
chlafreniere
chlafreniere reviewed Jul 3, 2023
View reviewed changes
extensions/mssql/src/objectManagement/commands.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/commands.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/interfaces.ts Show resolved Hide resolved
extensions/mssql/src/objectManagement/interfaces.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/localizedConstants.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/localizedConstants.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/objectManagementService.ts Show resolved Hide resolved
extensions/mssql/src/objectManagement/utils.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/utils.ts Outdated Show resolved Hide resolved
@ssreerama ssreerama self-assigned this Jul 5, 2023
@ssreerama ssreerama linked an issue Jul 5, 2023 that may be closed by this pull request
Enable dialog experience with 'Options' Tab #23338
Closed
Charles-Gagnon
Charles-Gagnon reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on updating STS with your backend changes in this PR as well? Or get this in and then do a separate follow up PR?

@ssreerama
Copy link
Contributor Author

Are you planning on updating STS with your backend changes in this PR as well? Or get this in and then do a separate follow up PR?

I can go ahead and merge this one, and then raise a separate PR to update the sts version. Also, STS PR is out for review.

Charles-Gagnon
Charles-Gagnon approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on adding tests for stuff like the helper functions, but I'm fine if those come in after as a separate PR

@ssreerama
Copy link
Contributor Author

I have just added a test case to validate the utils helper method, but noticed the mssql tests are disabled in .\scripts\test-extensions-unit.bat file. did we disable them compltely?

@ssreerama ssreerama merged commit acfa93f into main Jul 6, 2023
@ssreerama ssreerama deleted the sai/optionsTab_dbProperties branch July 6, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinstellato-ms erinstellato-ms erinstellato-ms left review comments

@corivera corivera corivera left review comments

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@barbaravaldez barbaravaldez Awaiting requested review from barbaravaldez

@chlafreniere chlafreniere Awaiting requested review from chlafreniere

Assignees

@ssreerama ssreerama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable dialog experience with 'Options' Tab
5 participants
@ssreerama @corivera @Charles-Gagnon @chlafreniere @erinstellato-ms